Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/k8scluster] Change k8s.job metrics to use mdatagen #24182

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

povilasv
Copy link
Contributor

@povilasv povilasv commented Jul 11, 2023

Change k8s.job metrics to use mdatagen.

Link to tracking Issue: #4367

@github-actions github-actions bot requested a review from dmitryax July 11, 2023 11:15
@povilasv povilasv changed the title [receiver/k8scluster] Change k8s.job metric unit to follow otel [receiver/k8scluster] Change k8s.job metric unit to follow otel conventions Jul 11, 2023
@povilasv povilasv force-pushed the k8s-cluster-receiver-jobs branch 2 times, most recently from 63e948e to f337700 Compare July 11, 2023 11:55
@povilasv povilasv marked this pull request as ready for review July 11, 2023 12:47
@povilasv povilasv requested a review from a team July 11, 2023 12:47
@dmitryax
Copy link
Member

@povilasv can you please change this PR to have only pdata migration with no breaking changes for now? Then we will handle units separately as suggested in #24055 (comment)

@povilasv povilasv force-pushed the k8s-cluster-receiver-jobs branch from f337700 to cb363aa Compare July 13, 2023 10:44
@povilasv povilasv changed the title [receiver/k8scluster] Change k8s.job metric unit to follow otel conventions [receiver/k8scluster] Change k8s.job metrics to use mdatagen Jul 13, 2023
@dmitryax dmitryax merged commit 7dea812 into open-telemetry:main Jul 13, 2023
@github-actions github-actions bot added this to the next release milestone Jul 13, 2023
@povilasv povilasv deleted the k8s-cluster-receiver-jobs branch July 14, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants