[chore] give go cache download 5 minutes timeout #24178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
approved these changes
Jul 12, 2023
songy23
added
the
ready to merge
codeboten
approved these changes
Jul 12, 2023
|
We are hitting the timeout on Windows on most PRs on main
I would suggest reverting this or increasing the timeout on Windows, since I don't think these would have stalled indefinitely. |
codeboten
pushed a commit
to codeboten/opentelemetry-collector-contrib
that referenced
this pull request
Jul 13, 2023
…try#24178)" This reverts commit 6bc44a8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/5514105058/jobs/10053104650
When the go caching action takes more than 5 minutes, it is likely to stall indefinitely. Better to timeout early.