Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/k8scluster] Change k8s.cronjob.active_jobs to use mdatagen #24057

Merged
merged 3 commits into from
Jul 17, 2023
Merged

[receiver/k8scluster] Change k8s.cronjob.active_jobs to use mdatagen #24057

merged 3 commits into from
Jul 17, 2023

Conversation

povilasv
Copy link
Contributor

@povilasv povilasv commented Jul 10, 2023 •
edited
Loading

Description: Change k8s.cronjob.active_jobs to use mdatagen

Link to tracking Issue: #4367

@github-actions github-actions bot requested a review from dmitryax July 10, 2023 10:26
@povilasv povilasv force-pushed the k8s-cluster-receiver-cronjob branch 2 times, most recently from 47c9d1d to e45f8b4 Compare July 10, 2023 10:45
@povilasv povilasv changed the title [receiver/k8scluster] Change k8s.cronjob.active_job to k8s.cronjob.active_job_count [receiver/k8scluster] Deprecate k8s.cronjob.active_job in favor of k8s.cronjob.active_job_count Jul 10, 2023
@povilasv povilasv force-pushed the k8s-cluster-receiver-cronjob branch 4 times, most recently from d03afd1 to 5706b76 Compare July 10, 2023 11:57
@povilasv povilasv marked this pull request as ready for review July 10, 2023 14:56
@povilasv povilasv requested a review from a team July 10, 2023 14:56
@dmitryax
Copy link
Member

Same comment as in #24055

@povilasv povilasv force-pushed the k8s-cluster-receiver-cronjob branch from 5706b76 to dadcf70 Compare July 13, 2023 10:57
@povilasv povilasv changed the title [receiver/k8scluster] Deprecate k8s.cronjob.active_job in favor of k8s.cronjob.active_job_count [receiver/k8scluster] Change k8s.cronjob.active_job to use mdatagen Jul 13, 2023
@povilasv povilasv force-pushed the k8s-cluster-receiver-cronjob branch 2 times, most recently from deddf16 to 81a4c9f Compare July 13, 2023 11:16
@povilasv povilasv force-pushed the k8s-cluster-receiver-cronjob branch 2 times, most recently from bf8d60d to 8d01750 Compare July 14, 2023 11:22
@povilasv povilasv force-pushed the k8s-cluster-receiver-cronjob branch from 8d01750 to 28d3354 Compare July 14, 2023 11:22
@povilasv povilasv changed the title [receiver/k8scluster] Change k8s.cronjob.active_job to use mdatagen [receiver/k8scluster] Change k8s.cronjob.active_jobs to use mdatagen Jul 14, 2023
@povilasv
Copy link
Contributor Author

Thank you both for review! I'm ready for another one :)

@povilasv povilasv requested review from atoulme and dmitryax July 14, 2023 12:38
@dmitryax dmitryax merged commit 3f548bb into open-telemetry:main Jul 17, 2023
@github-actions github-actions bot added this to the next release milestone Jul 17, 2023
@povilasv povilasv deleted the k8s-cluster-receiver-cronjob branch July 18, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@atoulme atoulme Awaiting requested review from atoulme

Assignees

@kovrus kovrus

Labels
receiver/k8scluster
Projects
None yet
Milestone
v0.82.0
Development

Successfully merging this pull request may close these issues.
4 participants
@povilasv @dmitryax @atoulme @kovrus