Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/kafka] Add JSON-encoded log support #24028

Merged
merged 5 commits into from
Jul 10, 2023

Conversation

Caleb-Hurshman
Copy link
Contributor

Description:
Added support for json encoded logs to the kafkareceiver
Re-creation of pr #22982 after rebasing issues

Link to tracking Issue: #20734

Testing: Added tests for json_unmarshaler.go in json_unmarshaler_test.go, similar to existing 'unmarshaler' files.

Documentation: Updated README.md of the kafkareceiver to include the JSON encoding option.

@djaglowski
Copy link
Member

kafkareceiver/unmarshaler.go:78: File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/open-telemetry/opentelemetry-collector-contrib) (gci)
level=info msg="[runner] linters took 5.481112821s with stages: goanalysis_metalinter: 5.478905617s"
  json := newJSONLogsUnmarshaler()
kafkareceiver/unmarshaler.go:83: File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/open-telemetry/opentelemetry-collector-contrib) (gci)
    json.Encoding(): json,
kafkareceiver/unmarshaler_test.go:53: File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/open-telemetry/opentelemetry-collector-contrib) (gci)
    "json",

Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe all concerns mentioned on #22982 were resolved.

@djaglowski djaglowski merged commit 0e4cb4a into open-telemetry:main Jul 10, 2023
@github-actions github-actions bot added this to the next release milestone Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants