-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] update runner to latest #23816
Conversation
Fixes #16450 Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Reopening. Let's see if it's getting better. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 779 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
No there was an issue w/ cgroups permission + docker socket in the latest ubuntu. I tested some workaround but couldn't get it to work. I'm guessing we may need to change how rpm/deb packages are built in this repo if we want to see it work.... an alternative i hadn't thought about until just now would be to change those workflows to use the goreleaser since that's what we use in the releases repo anyways. |
That sounds sensible regardless of this bug. We found this bug because of rpm and deb testing of a systemd service in ubuntu docker images, and I'm not sure goreleaser deals with testing. |
Yeah I'm looking at alternatives for that test as well. Will follow up on this PR once I have something working |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Fixes #16450
Leaving in draft to test out the build w/ ubuntu-latest