Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] update runner to latest #23816

Closed
wants to merge 2 commits into from

Conversation

codeboten
Copy link
Contributor

Fixes #16450

Leaving in draft to test out the build w/ ubuntu-latest

Alex Boten added 2 commits June 28, 2023 10:26
Fixes #16450

Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 13, 2023
@github-actions
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Jul 28, 2023
@atoulme atoulme reopened this Oct 30, 2023
@atoulme
Copy link
Contributor

atoulme commented Oct 30, 2023

Reopening. Let's see if it's getting better.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

see 779 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@github-actions github-actions bot removed the Stale label Oct 31, 2023
@codeboten
Copy link
Contributor Author

Reopening. Let's see if it's getting better.

No there was an issue w/ cgroups permission + docker socket in the latest ubuntu. I tested some workaround but couldn't get it to work. I'm guessing we may need to change how rpm/deb packages are built in this repo if we want to see it work....

an alternative i hadn't thought about until just now would be to change those workflows to use the goreleaser since that's what we use in the releases repo anyways.

@atoulme
Copy link
Contributor

atoulme commented Oct 31, 2023

That sounds sensible regardless of this bug. We found this bug because of rpm and deb testing of a systemd service in ubuntu docker images, and I'm not sure goreleaser deals with testing.

@codeboten
Copy link
Contributor Author

That sounds sensible regardless of this bug. We found this bug because of rpm and deb testing of a systemd service in ubuntu docker images, and I'm not sure goreleaser deals with testing.

Yeah I'm looking at alternatives for that test as well. Will follow up on this PR once I have something working

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 16, 2023
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gh-actions] build-package jobs are failing on the ubuntu-22.04 runners
2 participants