Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NR expand kafka broker metrics #23646

Closed

Conversation

4demos
Copy link

@4demos 4demos commented Jun 22, 2023

Description:

Link to tracking Issue:

Testing:

Documentation:

@4demos 4demos requested a review from a team June 22, 2023 22:13
@4demos 4demos requested a review from dmitryax as a code owner June 22, 2023 22:13
@4demos
Copy link
Author

4demos commented Jun 22, 2023

@dmitryax here is the replacement of #22839

@dmitryax
Copy link
Member

Please resolve the CI failures

@4demos
Copy link
Author

4demos commented Jun 23, 2023

metrics data from sarama
[
75%,
95%,
99%,
99.9%,
count,
max,
mean,
median,
min,
stddev,
]

it doesn't look like we could fetch cumulative sum.

Though looks like the rates come from this source https://github.com/rcrowley/go-metrics/blob/master/meter.go
and there there are different rates: rate1, rate5, rate15, rateMean (this one returns mean rate of events per second), the rest \d+ -minute moving average rate

@dmitryax
Copy link
Member

Isn't count the cumulative sum?

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2023

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 27, 2023
@github-actions
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants