feat: intial draft sending medatada in prometheus remote write #23585
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The initial draft of creating Openmetrics metadata and sending them as part of Prometheus remote write request.
As of now the prometheus remote write is not sending metadata described in the linked issue as it should per per the otel spec. This is draft of a PR to address it.
This is not the final form, among other things it's missing tests, but I opened it to discuss from which part of the codebase should we send the metadata and whether introducing this should be behind a feature flag or configuration option.
Personally I lean towards just sending it as part of the same request and putting it behind a feature flag given the spec says the metadata should be sent I would eventually set is as default behavior.
TODO:
Link to tracking Issue: #13849
Testing: Locally only for now, will add tests and do more testing after getting feedback.
Documentation: