Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/iis] Fix error log when no items are in the request queue #23234

Merged

Conversation

BinaryFissionGames
Copy link
Contributor

Description:

  • Removes the error log when no items are in the request queue; Instead, a 0 will be recorded as the datapoint for iis.request.queue.age.max when no items are in the queue.

Link to tracking Issue: Closes #14575

Testing:

  • Added a test for situation where error is negative denominator, and when error is not a negative denominator
  • Update integration test payload with expected data
  • Ran manually on an IIS box, observed 0 is recorded and error is not logged.

@djaglowski
Copy link
Member

Thanks @BinaryFissionGames!

@djaglowski djaglowski merged commit 00e6b15 into open-telemetry:main Jun 8, 2023
@github-actions github-actions bot added this to the next release milestone Jun 8, 2023
Caleb-Hurshman pushed a commit to observIQ/opentelemetry-collector-contrib that referenced this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[receiver/iis] iis.request.queue.age.maxconsistently fails to scrape
3 participants