-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] [pkg/translator/prometheus] Update documentation #23209
Merged
dmitryax
merged 1 commit into
open-telemetry:main
from
dmitryax:update-normalization-docs
Jun 7, 2023
Merged
[chore] [pkg/translator/prometheus] Update documentation #23209
dmitryax
merged 1 commit into
open-telemetry:main
from
dmitryax:update-normalization-docs
Jun 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
commented
Jun 6, 2023
Comment on lines
+23
to
+34
| Case | Transformation | Example | | ||
|----------------------------------------------------------|----------------------------------------------------------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------| | ||
| Unsupported characters and extraneous underscores | Replace unsupported characters with underscores (`_`). Drop redundant, leading and trailing underscores. | `(lambda).function.executions(#)` → `lambda_function_executions` | | ||
| Standard unit | Convert the unit from [Unified Code for Units of Measure](http://unitsofmeasure.org/ucum.html) to Prometheus standard and append | `system.filesystem.usage` with unit `By` → `system_filesystem_usage_bytes` | | ||
| Non-standard unit (unit is surrounded with `{}`) | Drop the unit | `system.network.dropped` with unit `{packets}` → `system_network_dropped` | | ||
| Non-standard unit (unit is **not** surrounded with `{}`) | Append the unit, if not already present, after sanitization (all non-alphanumeric chars are dropped) | `system.network.dropped` with unit `packets` → `system_network_dropped_packets` | | ||
| Percentages (unit is `1`) | Append `_ratio` (for gauges only) | `system.memory.utilization` with unit `1` → `system_memory_utilization_ratio` | | ||
| Percentages (unit is `%`) | Replace `%` with `percent` `_percent` | `storage.filesystem.utilization` with unit `%` → `storage_filesystem_utilization_percent` | | ||
| Rates (unit contains `/`) | Replace `/` with `per` | `astro.light.speed` with unit `m/s` → `astro_light_speed_meters_per_second` | | ||
| Dollars (unit is `$`) | Replace `$` with `dollars` | `crypto.dogecoin.value` with unit `$` → `crypto_dogecoin_value_dollars` | | ||
| Counter | Append `_total` | `system.processes.created` → `system_processes_created_total` | | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block doesn't have any changes other than replacing ==>
with →
and fixing crypto.dogecoin.value_dollars
with crypto_dogecoin_value_dollars
dmitryax
force-pushed
the
update-normalization-docs
branch
from
June 6, 2023 23:31
4f4edfc
to
3a7dec2
Compare
dmitryax
changed the title
[chore] [pkg/translator/prometheus] Document Prometheus->OTel conversion
[chore] [pkg/translator/prometheus] Update Readme
Jun 6, 2023
dmitryax
changed the title
[chore] [pkg/translator/prometheus] Update Readme
[chore] [pkg/translator/prometheus] Update documentation
Jun 6, 2023
crobert-1
approved these changes
Jun 7, 2023
dmitryax
force-pushed
the
update-normalization-docs
branch
2 times, most recently
from
June 7, 2023 06:18
5de2393
to
371ea99
Compare
songy23
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Describe transformations currently applied in the Prometheus receiver in README.md
dmitryax
force-pushed
the
update-normalization-docs
branch
from
June 7, 2023 15:46
371ea99
to
2da3530
Compare
Caleb-Hurshman
pushed a commit
to observIQ/opentelemetry-collector-contrib
that referenced
this pull request
Jul 6, 2023
…try#23209) - Describe transformations currently applied in the Prometheus receiver - Fix `crypto.dogecoin.value_dollars`-> `crypto_dogecoin_value_dollars` typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crypto.dogecoin.value_dollars
->crypto_dogecoin_value_dollars
typoMissing translations reported in #23208