Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] [processor/k8sattributes] Add a extract::metadata warning #23146

Closed
wants to merge 2 commits into from

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Jun 6, 2023

Show a warning when extract::metadata is not provided explicitly saying that the default value is going to be changed

Prepare for #23136

@dmitryax dmitryax requested a review from a team June 6, 2023 06:08
@dmitryax dmitryax requested a review from fatsheep9146 as a code owner June 6, 2023 06:08
@github-actions github-actions bot added the processor/k8sattributes k8s Attributes processor label Jun 6, 2023
@github-actions github-actions bot requested a review from rmfitzpatrick June 6, 2023 06:08
@dmitryax dmitryax force-pushed the k8s-attrs-add-warning branch from 058acde to bf613d0 Compare June 6, 2023 06:26
Show a warning when extract::metadata is not provided explicitly saying that the default value is going to be changed
@dmitryax dmitryax force-pushed the k8s-attrs-add-warning branch from bf613d0 to d5e4a74 Compare June 6, 2023 06:35
processor/k8sattributesprocessor/factory.go Outdated Show resolved Hide resolved
@dmitryax
Copy link
Member Author

dmitryax commented Jun 6, 2023

I'm converting this to draft for now, see #23136 (comment)

@dmitryax dmitryax marked this pull request as draft June 6, 2023 18:16
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jun 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processor/k8sattributes k8s Attributes processor Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants