Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/dockerstats] adding renamed cpu_utilization metric #22823

Merged

Conversation

carlossscastro
Copy link
Contributor

Description:
This change starts the process for deprecating the metric container.cpu.percent in favor of container.cpu.utilization to adhere to semantic convention.

At this step introducing the new metric name disabled by default, leaving the old metric enabled

Link to tracking Issue: #21807

Testing:

❯ go clean -testcache
❯ make test
go test -race -timeout 300s -parallel 4 --tags="" ./...
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/dockerstatsreceiver	0.759s
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/dockerstatsreceiver/internal/metadata	0.325s
❯ go test --tags integration ./...
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/dockerstatsreceiver	16.050s
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/dockerstatsreceiver/internal/metadata	0.209s

Documentation:
Metrics documentation was updated using mdatagen

@carlossscastro
Copy link
Contributor Author

@atoulme
New PR with the changes suggested in #22159

@songy23 songy23 changed the title adding renamed cpu_utilization metric [receiver/dockerstats] adding renamed cpu_utilization metric May 30, 2023
@songy23
Copy link
Member

songy23 commented May 30, 2023

cc @gbbr

@dmitryax dmitryax merged commit a33b902 into open-telemetry:main Jun 2, 2023
@dmitryax
Copy link
Member

dmitryax commented Jun 2, 2023

Thanks, @carlossscastro!

@github-actions github-actions bot added this to the next release milestone Jun 2, 2023
sigilioso added a commit to gsanchezgavier/entity-synthesis-definitions that referenced this pull request Jun 13, 2023
It uses the metric defined in <open-telemetry/opentelemetry-collector-contrib#22823>
Released after OpenTelemetry Collector Contrib v0.79.0
marcsanmi pushed a commit to gsanchezgavier/entity-synthesis-definitions that referenced this pull request Jun 22, 2023
It uses the metric defined in <open-telemetry/opentelemetry-collector-contrib#22823>
Released after OpenTelemetry Collector Contrib v0.79.0
Caleb-Hurshman pushed a commit to observIQ/opentelemetry-collector-contrib that referenced this pull request Jul 6, 2023
…lemetry#22823)

This change starts the process for deprecating the metric container.cpu.percent in favor of container.cpu.utilization to adhere to semantic convention.

At this step introducing the new metric name disabled by default, leaving the old metric enabled
marcsanmi pushed a commit to gsanchezgavier/entity-synthesis-definitions that referenced this pull request Jul 10, 2023
It uses the metric defined in <open-telemetry/opentelemetry-collector-contrib#22823>
Released after OpenTelemetry Collector Contrib v0.79.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants