Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/datasetexporter]: Enable in internal components #22700

Conversation

martin-majlis-s1
Copy link
Contributor

Description: Enable datasetexporter in internal/components

Based on the instructions I have to enable datasetexporter in the internal/components.

Related PRs:

Add into OpenTelemetry-collector-release - open-telemetry/opentelemetry-collector-releases#338

Link to tracking Issue: #20660

Testing:

Documentation:

@martin-majlis-s1
Copy link
Contributor Author

It looks that I have messed up something. When I do:

cd cmd/configschema
make test

It fails with the same error as the CI:

go test -race -timeout 300s -parallel 4 --tags="" ./...
../../internal/components/components.go:33:2: no required module provides package github.com/open-telemetry/opentelemetry-collector-contrib/exporter/datasetexporter; to add it:
        go get github.com/open-telemetry/opentelemetry-collector-contrib/exporter/datasetexporter
make: *** [test] Error 1

However when I try to run:

 go get github.com/open-telemetry/opentelemetry-collector-contrib/exporter/datasetexporter
go: module github.com/open-telemetry/opentelemetry-collector-contrib@upgrade found (v0.77.0, replaced by ../..), but does not contain package github.com/open-telemetry/opentelemetry-collector-contrib/exporter/datasetexporter

Maybe it's related to the release process - https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/release.md#release-schedule - that should be driven by @bogdandrutu ?

@github-actions github-actions bot added the cmd/configschema configschema command label May 23, 2023
@github-actions github-actions bot requested a review from pmcollins May 23, 2023 08:40
@martin-majlis-s1
Copy link
Contributor Author

So it looks that release to v0.78.1 already happened - #22162. In the same time - https://hub.docker.com/r/otel/opentelemetry-collector-contrib/tags - docker image is not there yet.

@mx-psi mx-psi added the Run Windows Enable running windows test on a PR label May 23, 2023
@mx-psi mx-psi merged commit 93192ac into open-telemetry:main May 23, 2023
@github-actions github-actions bot added this to the next release milestone May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/configschema configschema command Run Windows Enable running windows test on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants