[RedisReceiver] Add service.instance.id as an additional resource attribute #22046
Conversation
| component: "redisreceiver" | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Adds service.instance.id as a resource parameter to redis receiver. |
There was a problem hiding this comment.
| note: Adds service.instance.id as a resource parameter to redis receiver. | |
| note: Adds service.instance.id as an additional resource attribute (disabled by default) to redis receiver. |
|
@hughesjj thanks for fixing some issues along the way! Can you please submit them in different PRs to keep the git history clean? And I believe all of them deserve separate changelog entries |
|
@dmitryax Yeah, sure! How about one for the bugfixes (removing I could further split up the proposed "bugfixes" PR into different PRs too, nbd either way, lmk |
|
The best practice is to apply each change in a separate PR especially if they are independent |
|
Please rebase |
hughesjj
force-pushed
the
redis_add_instanceid
branch
from
7d3027e to
60ef2a3
Compare
hughesjj
force-pushed
the
redis_add_instanceid
branch
from
60ef2a3 to
b75aae2
Compare
|
Please update the PR description |
hughesjj
changed the title
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Description:
Add a resource_attribute to track
service.instance.idand set the value of such to be the configuration's endpointLink to tracking Issue:
#22044
Testing:
Ran test in intellij
Documentation:
I believe mdatagen takes care of this but can add to README too. LMK if you think I should.