-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/datasetexporter]: Fix failing test on windows #22041
[exporter/datasetexporter]: Fix failing test on windows #22041
Conversation
Library |
@mx-psi : This is the PR, where I am trying to figure out, why is it failing. |
@martin-majlis-s1 I added the 'Run Windows' label. Future commits to the PR's branch will run the test suite on Windows. |
Message - " socket: The requested service provider could not be loaded or initialized." - is universal message in windows. This is happening when the application does not have permissions - https://travis-ci.community/t/socket-the-requested-service-provider-could-not-be-loaded-or-initialized/1127 - but it's really strange, since it is used by everybody - #22041 (comment) |
This is the line in I will stare on it tomorrow. I am not able to figure out, where it differs. |
@mx-psi : I can remove/skip that test and then I can try to figure out, why is that test failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix lint
So the final finding is that it's cause by the library - https://pkg.go.dev/github.com/stretchr/testify/suite. Once I have removed it - it started to work. It's no clear to me why. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description: In the PR #21815 I have added code for dataset exporter. However test for windows - https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/5002859274/jobs/8963342956 - is failing. So let's fix it.
Link to tracking Issue: #22039, #20660
Testing:
The issue is caused by the github.com/stretchr/testify/suite package. Once I have removed it started to work.