[chore] [internal/splunk] Don't use pointer for Event.Time field value #22030
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pointer was added in #1157 to avoid sending zero timestamps by Splunk HEC exporter. But using a pointer is not required for that,
json:omitempty
tag does the same for float64 zero values.After this change, we cannot differentiate
nil
/0
values ofTime
field in the internalsplunk.Event
struct, but it doesn't matter because both versions produce the same JSON string withouttime
field and translates to/from the same OTLP0
values.Before:
After: