fileexporter/receiver: refactor fileexporter and read compressed json in filereceiver #22021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cmd/configschema
github-actions
bot
requested review from
atingchen,
djaglowski,
dmitryax,
mx-psi and
pmcollins
|
Before you push too much into this, please know this PR's scope is too big for review. Please break it in 2. |
jmacd
reviewed
May 17, 2023
Comment on lines
+100
to
+118
| if cfg.Compression == "zstd" { | ||
| if fw, err := zstd.NewWriter(file); err == nil { | ||
| // flushing the compressed writer every second. | ||
| go func() { | ||
| for { | ||
| time.Sleep(1 * time.Second) | ||
| if fw.Flush() != nil { | ||
| return | ||
| } | ||
| } | ||
| }() | ||
|
|
||
| return &lineWriter{ | ||
| file: bufio.NewWriter(fw), | ||
| } | ||
| } | ||
| } | ||
|
|
||
| return &lineWriter{ |
jmacd
reviewed
May 17, 2023
Comment on lines
+142
to
+157
| if cfg.Compression == "zstd" { | ||
| if fw, err := zstd.NewWriter(file); err == nil { | ||
| // flushing the compressed writer every second. | ||
| go func() { | ||
| for { | ||
| time.Sleep(1 * time.Second) | ||
| if fw.Flush() != nil { | ||
| return | ||
| } | ||
| } | ||
| }() | ||
| return &fileWriter{ | ||
| file: bufio.NewWriter(fw), | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This changes compression to be per-stream not per-record, which I think is OK as long as the reader (a) has never supported this, (b) will support this after your change.
This was referenced May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
[WIP] not working
This PR: