[receiver/statsdreceiver] update to use generated status #21286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
approved these changes
May 3, 2023
dmitryax
requested changes
May 3, 2023
atoulme
approved these changes
May 5, 2023
altuner
approved these changes
May 5, 2023
|
Please rebase, sorry, I added the splunk distro to this receiver. |
Signed-off-by: xin.li <[email protected]>
jmacd
approved these changes
May 18, 2023
codeboten
reviewed
May 19, 2023
There was a problem hiding this comment.
Please update the factory to use the generated Type and Stability consts here:
opentelemetry-collector-contrib/receiver/statsdreceiver/factory.go
Lines 20 to 21 in 96bed57
| class: receiver | ||
| stability: | ||
| beta: [metrics] | ||
| distributions: [contrib, splunk] |
There was a problem hiding this comment.
Needs another rebase, sumo was added. Sorry for all the churn @my-git9
There was a problem hiding this comment.
I fixed the conflict with the github UI, lemme know if that works.
There was a problem hiding this comment.
This is still unresolved. sumo is added in the doc only, not here
There was a problem hiding this comment.
I pushed 2 more commits to get this synchronized
codeboten
approved these changes
May 23, 2023
dmitryax
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Link to tracking Issue:
#21213
Testing:
Documentation: