Revert "[receiver/filelog][pkg/stanza] Prevent a lot of errors on windows if the path contains Junction" #21195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
approved these changes
Apr 26, 2023
|
@djaglowski My appologize for the problems in the rush... ! Can I reopen the original issue ? I can do a new PR. But anyway this problem needs to be fixed. |
|
Thanks @gillg. I think your assessment is correct. Here's a link to the failures. These were resolved by reverting the PR. I should have remembered to enable windows unit tests on the PR - will make sure to do so on the next one. I've reopened the original issue for tracking purposes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #20732
This caused some failures. We need to apply the
Run Windowslabel to ensure that tests are updated accordingly.