Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rectifying the histogram configuration parameter #21163

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Rectifying the histogram configuration parameter #21163

merged 1 commit into from
Apr 25, 2023

Conversation

datsabk
Copy link
Contributor

@datsabk datsabk commented Apr 25, 2023

Description:
Fixing Issue #21157

Testing:
Tested the configuration in Kubernetes cluster

datadog:
    api:
      key: xx
      site: datadoghq.com
    metrics:
      resource_attributes_as_tags: true
      histograms:
        send_aggregation_metrics: true
    host_metadata:
      enabled: true

Documentation:
Corrected the example collector.yaml that was having the incorrect content

@datsabk datsabk requested a review from a team April 25, 2023 14:25
@datsabk datsabk requested a review from mx-psi as a code owner April 25, 2023 14:25
@github-actions github-actions bot added the exporter/datadog Datadog components label Apr 25, 2023
mx-psi
mx-psi approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @datsabk :)

@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 25, 2023
@mx-psi mx-psi linked an issue Apr 25, 2023 that may be closed by this pull request
Datadog Exporter configuration is not correctly documented #21157
Closed
@datsabk
Copy link
Contributor Author

datsabk commented Apr 25, 2023

@mx-psi - I'm unfortunately not authorised to merge this one (being my first here). Hoping you could do the merge.

@datsabk
Copy link
Contributor Author

datsabk commented Apr 25, 2023

The action failure appears to be a missing distribution file in Ubuntu updates.

@mx-psi mx-psi merged commit 5f992df into open-telemetry:main Apr 25, 2023
@github-actions github-actions bot added this to the next release milestone Apr 25, 2023
@datsabk datsabk deleted the datadog-histogram-config-patch branch April 25, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

@dineshg13 dineshg13 Awaiting requested review from dineshg13

@gbbr gbbr Awaiting requested review from gbbr

@liustanley liustanley Awaiting requested review from liustanley

@songy23 songy23 Awaiting requested review from songy23 songy23 is a code owner

Assignees

@atoulme atoulme

Labels
exporter/datadog Datadog components Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.76.3
Development

Successfully merging this pull request may close these issues.

Datadog Exporter configuration is not correctly documented
3 participants
@datsabk @mx-psi @atoulme