Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] fix: using replace_all_patterns on logs makes attributes values empty #21117

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

Ishmeet
Copy link
Contributor

@Ishmeet Ishmeet commented Apr 24, 2023

Description:
#21109
replace_all_patterns on logs were getting empty values when attributes values was other than string. This fixes that.

@TylerHelmuth

Ex. Adding a feature - Explain what this achieves.-->

Link to tracking Issue:

Testing:

Documentation:

@Ishmeet Ishmeet requested a review from a team April 24, 2023 17:23
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 24, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Ishmeet / name: Ishmeet (ac7788d)

@atoulme
Copy link
Contributor

atoulme commented Apr 24, 2023

Please add a CHANGELOG entry. Please add a test to cover this fix.

@Ishmeet Ishmeet changed the title fix: using replace_all_patterns on logs makes attributes values empty [chore] fix: using replace_all_patterns on logs makes attributes values empty Apr 27, 2023
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ishmeet please sign the CLA and ensure that the email used to sign is the email associated with each commit in the PR.

.chloggen/fix-func-replace-all-patterns.yaml Outdated Show resolved Hide resolved
@TylerHelmuth TylerHelmuth merged commit 95c0149 into open-telemetry:main Apr 27, 2023
@github-actions github-actions bot added this to the next release milestone Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[transform processor]: using replace_all_patterns on logs makes attributes values empty
4 participants