exporter/datadogexporter: update github.com/DataDog/datadog-agent/pkg/trace. #20923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/trace. This PR updates `github.com/DataDog/datadog-agent/pkg/trace` to `v0.45.0-rc.1`. **Context:** The following [PR](open-telemetry#20286) had pinned a pseudoversion of `github.com/DataDog/datadog-agent/pkg/trace` (`v0.44.0-rc.4.0.20230322085447-8b27e87df01c`) which was required in order to take advantages of the following [commit](DataDog/datadog-agent@8b27e87). This was later updated by Dependabot from `v0.44.0-rc.4.0.20230322085447-8b27e87df01c` to `0.44.0-rc.5` in this [PR](open-telemetry#20486). `0.44.0-rc.5` does not contain changes from the required [commit](DataDog/datadog-agent@8b27e87) (milestone `7.45.0`). This PR now re-adds the changes back by updating to `v0.45.0-rc.1`. Because the latest release contains `github.com/DataDog/datadog-agent/pkg/trace` `v0.44.0-rc.5`, which does not contain the changes from the following [commit](DataDog/datadog-agent@8b27e87), this brings two issues: - the span links change was not added in the latest release, but it was added to the release notes => This PR adds a `bug_fix` changelog to indicate this. - in the latest release, the hostname preview logic is off by default, instead of on by default (due to the removal of the following [setting](https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/20286/files#diff-9ca998552699e406631ae1a165fef81d5373ba6876136c8c48c10ae0355edf2aL179) which only works in combination of the required [commit](DataDog/datadog-agent@8b27e87)) => This PR adds a `bug_fix` changelog to indicate this. It also adds the changelog related to [PR1](DataDog/datadog-agent#16337) and [PR2](DataDog/datadog-agent#16430), which are brought in from the upgrade to `v0.45.0-rc.1`.
github-actions
bot
added
cmd/configschema
github-actions
bot
requested review from
dineshg13,
gbbr,
liustanley,
pmcollins and
songy23
songy23
approved these changes
Apr 17, 2023
Co-authored-by: Yang Song <[email protected]>
mx-psi
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates
github.com/DataDog/datadog-agent/pkg/tracetov0.45.0-rc.1.Context: The following PR had pinned a pseudoversion of
github.com/DataDog/datadog-agent/pkg/trace(v0.44.0-rc.4.0.20230322085447-8b27e87df01c) which was required in order to take advantages of the following commit.This was later updated by dependabot from
v0.44.0-rc.4.0.20230322085447-8b27e87df01cto0.44.0-rc.5in this PR.0.44.0-rc.5does not contain changes from the required commit (because the commit belongs to milestone7.45.0).This PR now adds the changes back by updating to
v0.45.0-rc.1.Because the latest release contains
github.com/DataDog/datadog-agent/pkg/tracev0.44.0-rc.5, which does not contain the changes from the following commit, this brings two issues:bug_fixchangelog to indicate this.exporter.datadog.hostname.previewfeature gate was graduated to stable, hostname detection was set to the behaviour of the feature gate disabled, instead of enabled (due to the removal of the following setting which only works in combination with the required commit) => This PR adds abug_fixchangelog to indicate this.It also adds the changelog related to PR1 and PR2, which are brought in from the upgrade to
v0.45.0-rc.1.