Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/purefb] New Pure Storage FlashBlade receiver #17906

Merged

Conversation

dgoscn
Copy link
Contributor

@dgoscn dgoscn commented Jan 22, 2023

Description:
New Pure Storage FlashBlade receiver component

Link to tracking Issue:
Closes #17528

Testing:
Just following the README.md is enough to get the correct results

Documentation:
The documentation still in development due to the stability of the receiver

@dgoscn dgoscn requested review from a team and codeboten January 22, 2023 23:34
@runforesight
Copy link

runforesight bot commented Jan 22, 2023

Foresight Summary

    
Major Impacts

build-and-test-windows duration(5 seconds) has decreased 41 minutes 13 seconds compared to main branch avg(41 minutes 18 seconds).
View More Details

⭕  build-and-test-windows workflow has finished in 5 seconds (41 minutes 10 seconds less than main branch avg.) and finished at 25th Jan, 2023.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  tracegen workflow has finished in 55 seconds (1 minute 33 seconds less than main branch avg.) and finished at 25th Jan, 2023.


Job Failed Steps Tests
publish-latest -     🔗  N/A See Details
build-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  telemetrygen workflow has finished in 58 seconds (1 minute 30 seconds less than main branch avg.) and finished at 25th Jan, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  check-links workflow has finished in 1 minute 34 seconds and finished at 25th Jan, 2023.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  changelog workflow has finished in 2 minutes 7 seconds and finished at 25th Jan, 2023.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 10 minutes 54 seconds (⚠️ 3 minutes 18 seconds more than main branch avg.) and finished at 25th Jan, 2023.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

✅  build-and-test workflow has finished in 44 minutes 30 seconds (7 minutes 39 seconds less than main branch avg.) and finished at 25th Jan, 2023.


Job Failed Steps Tests
correctness-metrics -     🔗  ✅ 2  ❌ 0  ⏭ 0    🔗 See Details
correctness-traces -     🔗  ✅ 17  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, internal) -     🔗  ✅ 561  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, internal) -     🔗  ✅ 561  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, extension) -     🔗  ✅ 528  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, extension) -     🔗  ✅ 528  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, processor) -     🔗  ✅ 1471  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, processor) -     🔗  ✅ 1471  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-0) -     🔗  ✅ 2567  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-0) -     🔗  ✅ 2567  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, exporter) -     🔗  ✅ 2429  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, other) -     🔗  ✅ 4630  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-1) -     🔗  ✅ 1905  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-1) -     🔗  ✅ 1905  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, exporter) -     🔗  ✅ 2429  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, other) -     🔗  ✅ 4630  ❌ 0  ⏭ 0    🔗 See Details
integration-tests -     🔗  ✅ 55  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details
lint-matrix (receiver-0) -     🔗  N/A See Details
lint-matrix (receiver-1) -     🔗  N/A See Details
lint-matrix (processor) -     🔗  N/A See Details
lint-matrix (exporter) -     🔗  N/A See Details
lint-matrix (extension) -     🔗  N/A See Details
lint-matrix (internal) -     🔗  N/A See Details
lint-matrix (other) -     🔗  N/A See Details
check-collector-module-version -     🔗  N/A See Details
check-codeowners -     🔗  N/A See Details
checks -     🔗  N/A See Details
build-examples -     🔗  N/A See Details
unittest (1.19) -     🔗  N/A See Details
unittest (1.18) -     🔗  N/A See Details
lint -     🔗  N/A See Details
cross-compile (darwin, amd64) -     🔗  N/A See Details
cross-compile (darwin, arm64) -     🔗  N/A See Details
cross-compile (linux, 386) -     🔗  N/A See Details
cross-compile (linux, amd64) -     🔗  N/A See Details
cross-compile (linux, arm) -     🔗  N/A See Details
cross-compile (linux, arm64) -     🔗  N/A See Details
cross-compile (linux, ppc64le) -     🔗  N/A See Details
cross-compile (windows, 386) -     🔗  N/A See Details
cross-compile (windows, amd64) -     🔗  N/A See Details
build-package (deb) -     🔗  N/A See Details
build-package (rpm) -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details

✅  load-tests workflow has finished in 17 minutes 40 seconds (⚠️ 3 minutes 18 seconds more than main branch avg.) and finished at 25th Jan, 2023.


Job Failed Steps Tests
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 19  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@dgoscn
Copy link
Contributor Author

dgoscn commented Jan 22, 2023

cc @jpkrohling

@jpkrohling jpkrohling requested review from jpkrohling and removed request for codeboten January 23, 2023 11:07
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but the Validate function needs a small adjustment.

receiver/purefbreceiver/config.go Outdated Show resolved Hide resolved
receiver/purefbreceiver/config.go Outdated Show resolved Hide resolved
@jpkrohling
Copy link
Member

Please, fix the conflict on the go.mod file. Once that's done, and once @chrroberts-pure approves, I'll merge this.

Copy link
Contributor

@chrroberts-pure chrroberts-pure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits, but otherwise LGTM

receiver/purefbreceiver/config_test.go Outdated Show resolved Hide resolved
receiver/purefbreceiver/factory.go Outdated Show resolved Hide resolved
receiver/purefbreceiver/testdata/config.yaml Outdated Show resolved Hide resolved
@dgoscn
Copy link
Contributor Author

dgoscn commented Jan 24, 2023

Hi @jpkrohling and @chrroberts-pure can you please double check the updated files from review?
Thank you

Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small details which wouldn't block this, but it looks like there's something outdated with this PR. The CI says:

Replace statements are out of date, please run "make crosslink" and commit the changes in this PR.

receiver/purefbreceiver/README.md Outdated Show resolved Hide resolved
receiver/purefbreceiver/factory.go Outdated Show resolved Hide resolved
receiver/purefbreceiver/internal/scraper_test.go Outdated Show resolved Hide resolved
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found another issue, but this can be fixed on a follow-up PR if CI allows.

receiver/purefbreceiver/go.mod Outdated Show resolved Hide resolved
receiver/purefbreceiver/go.mod Outdated Show resolved Hide resolved
@github-actions github-actions bot added cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command cmd/oteltestbedcol labels Jan 24, 2023
@github-actions github-actions bot requested a review from pmcollins January 24, 2023 19:53
@jpkrohling jpkrohling force-pushed the purestorage_flashblade_receiver branch 2 times, most recently from 4cbdc99 to 9160873 Compare January 25, 2023 12:10
@jpkrohling jpkrohling force-pushed the purestorage_flashblade_receiver branch from 9160873 to ff744c9 Compare January 25, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command cmd/oteltestbedcol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New component: Pure Storage Receiver for FlashBlade
4 participants