Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/mysql]: add mysql.commands metric with support for delete, insert, select, update #17589

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

sumo-drosiek
Copy link
Member

Description:

add mysql.commands metric with support for delete, insert, select, update

reopening of #14735

Link to tracking Issue:

#14138

Testing:

unit tests

Documentation:

metadata.yaml

…e, insert, select, update

Signed-off-by: Dominik Rosiek <[email protected]>
@sumo-drosiek sumo-drosiek requested a review from a team January 16, 2023 10:42
@runforesight
Copy link

runforesight bot commented Jan 16, 2023

Foresight Summary

    
Major Impacts

build-and-test-windows duration(5 seconds) has decreased 42 minutes compared to main branch avg(42 minutes 5 seconds).
View More Details

⭕  build-and-test-windows workflow has finished in 5 seconds (42 minutes 32 seconds less than main branch avg.) and finished at 16th Jan, 2023.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  tracegen workflow has finished in 17 minutes 28 seconds (⚠️ 15 minutes 15 seconds more than main branch avg.) and finished at 16th Jan, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  telemetrygen workflow has finished in 18 minutes 8 seconds (⚠️ 15 minutes 45 seconds more than main branch avg.) and finished at 16th Jan, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  changelog workflow has finished in 21 minutes 33 seconds (⚠️ 19 minutes 28 seconds more than main branch avg.) and finished at 16th Jan, 2023.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

✅  check-links workflow has finished in 26 minutes 41 seconds (⚠️ 25 minutes 4 seconds more than main branch avg.) and finished at 16th Jan, 2023.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 29 minutes 26 seconds (⚠️ 22 minutes 6 seconds more than main branch avg.) and finished at 16th Jan, 2023.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

✅  load-tests workflow has finished in 41 minutes 9 seconds (⚠️ 27 minutes 4 seconds more than main branch avg.) and finished at 16th Jan, 2023.


Job Failed Steps Tests
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 19  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

✅  build-and-test workflow has finished in 40 minutes 8 seconds (6 minutes 59 seconds less than main branch avg.) and finished at 17th Jan, 2023.


Job Failed Steps Tests
lint-matrix (other) -     🔗  N/A See Details
lint -     🔗  N/A See Details
cross-compile (darwin, amd64) -     🔗  N/A See Details
cross-compile (darwin, arm64) -     🔗  N/A See Details
cross-compile (linux, 386) -     🔗  N/A See Details
cross-compile (linux, amd64) -     🔗  N/A See Details
cross-compile (linux, arm) -     🔗  N/A See Details
cross-compile (linux, arm64) -     🔗  N/A See Details
cross-compile (linux, ppc64le) -     🔗  N/A See Details
cross-compile (windows, 386) -     🔗  N/A See Details
cross-compile (windows, amd64) -     🔗  N/A See Details
build-package (deb) -     🔗  N/A See Details
build-package (rpm) -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience working through the design and deprecation process, @sumo-drosiek. Glad to finally have this in place as we decided.

@djaglowski djaglowski merged commit b72951b into open-telemetry:main Jan 17, 2023
@sumo-drosiek sumo-drosiek deleted the drosiek-mysql-commands branch January 18, 2023 07:21
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants