[mdatagen] Rename metadata.yaml attribute field value -> name_override #16561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cmd/mdatagen
github-actions
bot
requested review from
antonblock,
BinaryFissionGames,
cpheps,
dehaansa,
JonathanWamsley,
Mrod1598,
schmikei and
StefanKurek
`value` is a confusing name for an optional field that is used to override the attribute name defined in the key
dmitryax
force-pushed
the
mdatagen-rename-attribute-value
branch
from
0861119 to
1eb3d7d
Compare
djaglowski
approved these changes
Dec 1, 2022
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
open-telemetry#16561) `value` is a confusing name for an optional field that is used to override the attribute name defined in the key
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
valueis a confusing name for an optional field that is used to override the attribute name defined in the key