[pkg/ottl] Update IsMatch to convert bool int and float to strings #16503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
requested review from
bogdandrutu and
evan-bradley
as code owners
evan-bradley
approved these changes
Nov 28, 2022
Co-authored-by: Evan Bradley <[email protected]>
bogdandrutu
reviewed
Nov 28, 2022
bogdandrutu
approved these changes
Nov 28, 2022
bogdandrutu
approved these changes
Nov 29, 2022
Co-authored-by: Bogdan Drutu <[email protected]>
bogdandrutu
approved these changes
Nov 29, 2022
TylerHelmuth
added
the
ready to merge
codeboten
approved these changes
Nov 29, 2022
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
…pen-telemetry#16503) Updates IsMatch to intelligently convert bools, ints, and floats to strings before matching with the regex. This helps with IsMatch and attributes usage. Co-authored-by: Evan Bradley <[email protected]> Co-authored-by: Bogdan Drutu <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updates
IsMatchto intelligently convert bools, ints, and floats to strings before matching with the regex. This helps with IsMatch and attributes usage.Link to tracking Issue:
Closes #16434
Testing:
Updated unit tests
Documentation:
Updated IsMatch documentation