-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/elasticsearch]: add scraping metrics on cluster level #16346
Merged
djaglowski
merged 7 commits into
open-telemetry:main
from
aboguszewski-sumo:add-cluster-level-metrics
Dec 5, 2022
Merged
[receiver/elasticsearch]: add scraping metrics on cluster level #16346
djaglowski
merged 7 commits into
open-telemetry:main
from
aboguszewski-sumo:add-cluster-level-metrics
Dec 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@djaglowski could this get reviewed soon? |
djaglowski
reviewed
Nov 28, 2022
djaglowski
reviewed
Nov 28, 2022
aboguszewski-sumo
force-pushed
the
add-cluster-level-metrics
branch
from
December 1, 2022 12:59
36006fe
to
f3f48b8
Compare
Foresight Summary
View More Details✅ build-and-test workflow has finished in 1 hour 1 minute 44 seconds (
|
Job | Failed Steps | Tests | |
---|---|---|---|
integration-tests | - 🔗 | ✅ 59 ❌ 0 ⏭ 0 🔗 | See Details |
setup-environment | - 🔗 | N/A | See Details |
check-collector-module-version | - 🔗 | N/A | See Details |
check-codeowners | - 🔗 | N/A | See Details |
checks | - 🔗 | N/A | See Details |
lint-matrix (receiver-0) | - 🔗 | N/A | See Details |
lint-matrix (receiver-1) | - 🔗 | N/A | See Details |
lint-matrix (processor) | - 🔗 | N/A | See Details |
lint-matrix (exporter) | - 🔗 | N/A | See Details |
lint-matrix (extension) | - 🔗 | N/A | See Details |
lint-matrix (internal) | - 🔗 | N/A | See Details |
lint-matrix (other) | - 🔗 | N/A | See Details |
correctness-traces | - 🔗 | N/A | See Details |
build-examples | - 🔗 | N/A | See Details |
unittest-matrix (1.19, receiver-0) | - 🔗 | N/A | See Details |
unittest-matrix (1.19, receiver-1) | - 🔗 | N/A | See Details |
unittest-matrix (1.19, processor) | - 🔗 | N/A | See Details |
unittest-matrix (1.19, exporter) | - 🔗 | N/A | See Details |
unittest-matrix (1.19, extension) | - 🔗 | N/A | See Details |
unittest-matrix (1.19, internal) | - 🔗 | N/A | See Details |
unittest-matrix (1.19, other) | - 🔗 | N/A | See Details |
unittest-matrix (1.18, receiver-0) | - 🔗 | N/A | See Details |
unittest-matrix (1.18, receiver-1) | - 🔗 | N/A | See Details |
unittest-matrix (1.18, processor) | - 🔗 | N/A | See Details |
unittest-matrix (1.18, exporter) | - 🔗 | N/A | See Details |
unittest-matrix (1.18, extension) | - 🔗 | N/A | See Details |
unittest-matrix (1.18, internal) | - 🔗 | N/A | See Details |
unittest-matrix (1.18, other) | - 🔗 | N/A | See Details |
correctness-metrics | - 🔗 | N/A | See Details |
lint | - 🔗 | N/A | See Details |
unittest (1.19) | - 🔗 | N/A | See Details |
unittest (1.18) | - 🔗 | N/A | See Details |
cross-compile (darwin, amd64) | - 🔗 | N/A | See Details |
cross-compile (darwin, arm64) | - 🔗 | N/A | See Details |
cross-compile (linux, 386) | - 🔗 | N/A | See Details |
cross-compile (linux, amd64) | - 🔗 | N/A | See Details |
cross-compile (linux, arm) | - 🔗 | N/A | See Details |
cross-compile (linux, arm64) | - 🔗 | N/A | See Details |
cross-compile (linux, ppc64le) | - 🔗 | N/A | See Details |
cross-compile (windows, 386) | - 🔗 | N/A | See Details |
cross-compile (windows, amd64) | - 🔗 | N/A | See Details |
build-package (deb) | - 🔗 | N/A | See Details |
build-package (rpm) | - 🔗 | N/A | See Details |
windows-msi | - 🔗 | N/A | See Details |
publish-check | - 🔗 | N/A | See Details |
publish-dev | - 🔗 | N/A | See Details |
publish-stable | - 🔗 | N/A | See Details |
*You can configure Foresight comments in your organization settings page.
djaglowski
approved these changes
Dec 1, 2022
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
…-telemetry#16346) * feat: add support for scraping cluster stats by the client
6 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The receiver now scrapes cluster-level metrics from
/_cluster/stats
endpoint.There were already some metrics sent with
elasticsearch.cluster.name
resource attribute, but they used different endpoint (/_cluster/health
). I added the newly emitted metrics to the same resource.Link to tracking Issue: #14635
Testing:
unit, integration
Documentation:
mdatagen