Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore]: fix port feature gate's description in apachereceiver #16280

Merged
merged 2 commits into from
Nov 15, 2022
Merged

[chore]: fix port feature gate's description in apachereceiver #16280

merged 2 commits into from
Nov 15, 2022

Conversation

aboguszewski-sumo
Copy link
Member

@aboguszewski-sumo aboguszewski-sumo commented Nov 14, 2022 •
edited
Loading

Description:
The description of feature gate receiver.apache.emitPortAsResourceAttribute had incorrect information (introduced by me). It informed about apache.server.name resource attribute instead of apache.server.port.

Link to tracking Issue: #14791

@aboguszewski-sumo aboguszewski-sumo requested a review from a team November 14, 2022 10:50
andrzej-stencel
andrzej-stencel approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@andrzej-stencel andrzej-stencel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉
Not sure if such a small change requires a changelog entry?

djaglowski
djaglowski approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, the changelog is not needed here. Otherwise looks good.

@aboguszewski-sumo aboguszewski-sumo changed the title [receiver/apache]: fix port feature gate's description chore(receiver/apache): fix port feature gate's description Nov 15, 2022
@github-actions github-actions bot requested a review from djaglowski November 15, 2022 07:25
@aboguszewski-sumo
Copy link
Member Author

Changelog removed.

@aboguszewski-sumo aboguszewski-sumo changed the title chore(receiver/apache): fix port feature gate's description [chore]: fix port feature gate's description in apachereceiver Nov 15, 2022
@djaglowski djaglowski added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 15, 2022
@djaglowski djaglowski merged commit 73f6384 into open-telemetry:main Nov 15, 2022
JaredTan95 pushed a commit to openinsight-proj/opentelemetry-collector-contrib that referenced this pull request Nov 21, 2022
@aboguszewski-sumo @JaredTan95
[chore]: fix port feature gate's description in apachereceiver (open-…
666ac15 
…telemetry#16280)

* fix: fix port feature gate's description

* remove changelog
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
@aboguszewski-sumo @shalper2
[chore]: fix port feature gate's description in apachereceiver (open-…
2e23265 
…telemetry#16280)

* fix: fix port feature gate's description

* remove changelog
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrzej-stencel andrzej-stencel andrzej-stencel approved these changes

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

Assignees

@djaglowski djaglowski

Labels
receiver/apache Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aboguszewski-sumo @djaglowski @andrzej-stencel