[pkg/stanza] Support to Customize bufio.SplitFunc #16272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atingchen
changed the title
djaglowski
reviewed
Nov 14, 2022
atingchen
force-pushed
the
feature/build-with-splitter
branch
from
b3ce208 to
8517958
Compare
djaglowski
reviewed
Nov 15, 2022
There was a problem hiding this comment.
@atingchen, thank you for iterating on this. This version looks much cleaner to me. I just have a couple minor comments.
Thank you,I'd love to hear your advice. |
djaglowski
approved these changes
Nov 16, 2022
JaredTan95
pushed a commit
to openinsight-proj/opentelemetry-collector-contrib
that referenced
this pull request
Nov 21, 2022
* add a new method BuildWithSplitFunc, this method can directly pass in a user-defined splitFunc
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
* add a new method BuildWithSplitFunc, this method can directly pass in a user-defined splitFunc
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Support to Customize bufio.SplitFunc
Link to tracking Issue:
#14593
Testing:
Unit test