[chore] Assign reviewers through API in ping code owners workflow #16254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-bradley
requested review from
a team,
mx-psi,
TylerHelmuth and
dmitryax
MovieStoreGuy
approved these changes
Nov 11, 2022
Also loop through owners list in the "add code owners to PR" workflow, as it is more comprehensible than the pipe.
evan-bradley
force-pushed
the
fix-ping-codeowners-pr
branch
from
b646e7e to
e570fd3
Compare
dmitryax
approved these changes
Nov 11, 2022
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
…en-telemetry#16254) Assign reviewers through API in ping code owners workflow Also loop through owners list in the "add code owners to PR" workflow, as it is more comprehensible than the pipe. Co-authored-by: Evan Bradley <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Assigns reviewers through the GitHub API in the "ping codeowners on PRs" workflow and ensure the workflow should never fail under ordinary circumstances. Also uses a loop for more comprehensible construction of the reviewers JSON list, the previous pipe had an issue in the situation where the PR author was also the last code owner in the list.