[exporter/awskinesisexporter] Adding region config #16233
Conversation
|
Apologies, I did forget it in my very tired state. |
|
@Aneurysm9 any updates regarding this? I urgently require a fix to this issue and will appreciate an update, thank you! |
| lo.Region = conf.AWS.Region | ||
| return nil | ||
| }) | ||
| } |
There was a problem hiding this comment.
How is this change tested?
There was a problem hiding this comment.
I've been thinking about this, I don't think I have a good answer atm.
Let me play with some ideas on how to expose this information.
There was a problem hiding this comment.
So how I wanted to do this and what came out are very different due to the fact the fact that using assert.EqualValues resulted in differences due to lambda references being stored.
The best alternative without doing much of a major refactor was to create an options type and redefine the kinesis.NewClient method.
MovieStoreGuy
requested review from
djaglowski,
dashpole,
jmacd,
dmitryax,
jpkrohling,
mx-psi,
TylerHelmuth,
jsuereth,
punya and
arminru
as code owners
github-actions
bot
added
cmd/configschema
mx-psi
removed request for
jpkrohling,
jsuereth,
punya,
dashpole,
jmacd,
djaglowski,
mx-psi,
dmitryax,
arminru,
TylerHelmuth and
a team
MovieStoreGuy
force-pushed
the
msg/chore-include-region
branch
from
c4b9f7b to
c4908ba
Compare
|
@codeboten anything left to address here? |
MovieStoreGuy
added
ready to merge
MovieStoreGuy
force-pushed
the
msg/chore-include-region
branch
from
c4908ba to
210bf91
Compare
MovieStoreGuy
force-pushed
the
msg/chore-include-region
branch
from
210bf91 to
fde67a9
Compare
MovieStoreGuy
added
the
ready to merge
|
ping @codeboten |
Description:
This was an oversight with the upgrade for the client to use
aws sdk v2Link to tracking Issue:
#16259
Testing:
NA
Documentation:
The documentation already exists.