[receiver/prometheusreceiver]: trim type and unit suffixes from metric name #16071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you put this behind the |
paivagustavo
changed the title
paivagustavo
force-pushed
the
gustavo/promreceiver/normalize_metric_suffixes
branch
from
ea6b8fd to
d8ca297
Compare
|
@dashpole I've guarded this with the featuregate as asked, and added some specific tests for this on the receiver side as well. |
Note that this case is valid in prometheus format, just not in OpenMetrics format. |
paivagustavo
force-pushed
the
gustavo/promreceiver/normalize_metric_suffixes
branch
3 times, most recently
from
feb607f to
9d23af1
Compare
That makes sense, reverted those tests changes :) |
paivagustavo
force-pushed
the
gustavo/promreceiver/normalize_metric_suffixes
branch
from
9d23af1 to
c592716
Compare
dashpole
reviewed
Nov 10, 2022
dashpole
reviewed
Nov 10, 2022
dashpole
reviewed
Nov 10, 2022
paivagustavo
force-pushed
the
gustavo/promreceiver/normalize_metric_suffixes
branch
from
354d892 to
79073b9
Compare
github-actions
bot
added
pkg/translator/prometheus
receiver/prometheusexec
receiver/prometheus
dashpole
reviewed
Nov 14, 2022
dashpole
approved these changes
Nov 14, 2022
|
Seems like @dashpole do you mind retrying please? |
Aneurysm9
approved these changes
Nov 14, 2022
paivagustavo
force-pushed
the
gustavo/promreceiver/normalize_metric_suffixes
branch
from
fdd1e62 to
5550604
Compare
codeboten
reviewed
Nov 15, 2022
jmacd
approved these changes
Nov 16, 2022
codeboten
approved these changes
Nov 18, 2022
JaredTan95
pushed a commit
to openinsight-proj/opentelemetry-collector-contrib
that referenced
this pull request
Nov 21, 2022
…c name (open-telemetry#16071) Trim type's and unit's suffixes from metric name as per otel specs. There was a lot of changes required to pass down a featuregate.Registry in order to be testable. The important bit in the receiver code path is the metricFamily.appendMetric which trims the suffixes when creating an OTLP metric. Units suffixes will only take effect when using the OpenMetrics format, since the prometheus parser doesn't support units. This is being guarded by the gate: --feature-gates=pkg.translator.prometheus.NormalizeName
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
…c name (open-telemetry#16071) Trim type's and unit's suffixes from metric name as per otel specs. There was a lot of changes required to pass down a featuregate.Registry in order to be testable. The important bit in the receiver code path is the metricFamily.appendMetric which trims the suffixes when creating an OTLP metric. Units suffixes will only take effect when using the OpenMetrics format, since the prometheus parser doesn't support units. This is being guarded by the gate: --feature-gates=pkg.translator.prometheus.NormalizeName
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Trim type's and unit's suffixes from metric name as per otel specs.
There was a lot of changes required to pass down a
featuregate.Registryin order to be testable. The important bit in the receiver code path is themetricFamily.appendMetricwhich trims the suffixes when creating an OTLP metric.Units suffixes will only take effect when using the OpenMetrics format, since the prometheus parser doesn't support units.
This is being guarded by the gate:
--feature-gates=pkg.translator.prometheus.NormalizeNameLink to tracking Issue: #8950
Testing: Units tests were added for the translator package, and prometheus receiver tests updated.