-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pkg/ottl] Update Parser to understand solo conditions #14918
[pkg/ottl] Update Parser to understand solo conditions #14918
Conversation
It looks good! @TylerHelmuth thanks for playing around with it. One comment that is not related to the essence of this PR: As mentioned before #14783 (comment) the transform processor can now parse both ... = NewParser(
statements,
WithFunctions(functions),
WithSettings(settings),
WithSupportedStatements(Statement.TRANSFORMATION),
) |
Yes we could add something like that in the future and use it during validation, but I think it could be added later in its own PR. |
condition: expression, | ||
}, nil | ||
} | ||
|
||
var parser = newParser() | ||
|
||
func parseStatement(raw string) (*parsedStatement, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably inline this method and in tests it should be ok to use parser.ParseString("", raw)
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Can I somehow help to move this idea forward? |
@kovrus I've been unable to make this work a priority as I've been working on other things. Are you able to take over? |
@TylerHelmuth I can try! I'll take a look at it the next week. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
No description provided.