-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/elasticsearch] Skip TestExporter_PushTraceRecord flasky test #14785
Merged
dmitryax
merged 7 commits into
open-telemetry:main
from
JaredTan95:fix_es_exporter_flasky_test
Oct 24, 2022
Merged
[exporter/elasticsearch] Skip TestExporter_PushTraceRecord flasky test #14785
dmitryax
merged 7 commits into
open-telemetry:main
from
JaredTan95:fix_es_exporter_flasky_test
Oct 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/skip-changelog |
JaredTan95
changed the title
Fix es exporter flasky test
Fix es exporter TestExporter_PushTraceRecord flasky test
Oct 8, 2022
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
@dmitryax hi, do you have time to help review this? |
dmitryax
changed the title
Fix es exporter TestExporter_PushTraceRecord flasky test
Skip TestExporter_PushTraceRecord flasky test
Oct 24, 2022
dmitryax
changed the title
Skip TestExporter_PushTraceRecord flasky test
[exporter/elasticsearch] Skip TestExporter_PushTraceRecord flasky test
Oct 24, 2022
dmitryax
added
Skip Changelog
PRs that do not require a CHANGELOG.md entry
and removed
Stale
labels
Oct 24, 2022
dmitryax
approved these changes
Oct 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but this is not a fix. Merging as a temporary remediation
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
open-telemetry#14785) Signed-off-by: jian.tan <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: fix #14759
Link to tracking Issue: #14759
Testing:
Documentation: