Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/stanza] move FlusherConfig and SplitterConfig to new file #14762

Merged

Conversation

atingchen
Copy link
Contributor

@atingchen atingchen commented Oct 6, 2022

Description:

move FlusherConfig and SplitterConfig from multiline file to new file.

Link to tracking Issue:
#14766

Testing:
unit test

@atingchen atingchen requested a review from a team October 6, 2022 17:53
@atingchen atingchen requested a review from djaglowski as a code owner October 6, 2022 17:53
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can remove the changelog

.chloggen/stanza-operator-move-struct.yaml Outdated Show resolved Hide resolved
@djaglowski djaglowski added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 6, 2022
@codeboten codeboten merged commit f247019 into open-telemetry:main Oct 6, 2022
@atingchen atingchen deleted the feature/move-flusher-and-splitter branch October 6, 2022 21:02
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
…telemetry#14762)

move FlusherConfig and SplitterConfig from multiline file to new file.
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants