Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/mysql] Add mysql.joins metric #14728

Conversation

sumo-drosiek
Copy link
Member

@sumo-drosiek sumo-drosiek commented Oct 5, 2022

Description:

add mysql.joins metric

Link to tracking Issue:
#14138

Testing:
unit tests

Documentation:
metadata.yaml

@sumo-drosiek sumo-drosiek requested a review from a team October 5, 2022 12:10
@sumo-drosiek sumo-drosiek force-pushed the drosiek-mysql-select-metric branch from 2896a72 to 368697a Compare October 6, 2022 04:14
@sumo-drosiek sumo-drosiek changed the title feat(mysqlreceiver): add mysql.select metric feat(mysqlreceiver): add mysql.joins metric Oct 6, 2022
@sumo-drosiek sumo-drosiek force-pushed the drosiek-mysql-select-metric branch from 368697a to 5bfda7f Compare October 6, 2022 04:38
@djaglowski
Copy link
Member

LGTM, but please resolve conflicts

@djaglowski djaglowski changed the title feat(mysqlreceiver): add mysql.joins metric [receiver/mysql] Add mysql.joins metric Oct 6, 2022
@sumo-drosiek sumo-drosiek force-pushed the drosiek-mysql-select-metric branch from 5bfda7f to 6aed57f Compare October 7, 2022 06:13
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 28, 2022
@djaglowski
Copy link
Member

Closed based on #15366

@djaglowski djaglowski closed this Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants