[pkg/stanza] readerFactory and Reader use helper.Encoding directly #14724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atingchen
force-pushed
the
feature/lookchen-move-struct
branch
from
33569d2 to
8d3b084
Compare
djaglowski
reviewed
Oct 6, 2022
djaglowski
approved these changes
Oct 6, 2022
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
…pen-telemetry#14724) * Move `FlusherConfig` and `SplitterConfig` from `multiline` file to new file
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is part of the work in PR #14605. I split it into several small PRs and gradually implemented the function of custom SplitFunc.
This PR implements that
Readerno longer relies onhelper.Splitterto decode data.In the next PR, I will try to gradually remove the
helper.Splitterandhelper.SplitterConfigstructures while keeping the function unchangedLink to tracking Issue:
#14766
Testing:
unit test.
Documentation: