[extension/sigv4authextension] Make sts_region default to region if value not provided
#14630
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aneurysm9
approved these changes
Oct 4, 2022
|
@mx-psi let me know if any changes are necessary before this can get merged, thanks! |
mx-psi
approved these changes
Oct 6, 2022
mx-psi
reviewed
Oct 6, 2022
| @@ -44,6 +44,10 @@ var _ config.Extension = (*Config)(nil) | |||
| // We aim to catch most errors here to ensure that we | |||
| // fail early and to avoid revalidating static data. | |||
| func (cfg *Config) Validate() error { | |||
There was a problem hiding this comment.
Validate should not modify the configuration. Since you are already doing that below, I am not going to block merging this PR because of it, but I would like you to create an issue to move this and the credsProvider line below to Unmarshal
There was a problem hiding this comment.
Will take care of this early next week!
mx-psi
approved these changes
Oct 6, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR makes the value
sts_regiondefault to the value ofregionif thests_regionvalue is not provided and theregionvalue is provided.Link to tracking Issue:
#14573
Testing:
config_test.gowas updatedDocumentation:
README.mdwas updated