[exporter/signalfxexporter] Drop datapoints with more than 36 dimensions #14625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dloucasfx
changed the title
dloucasfx
force-pushed
the
dim-validation
branch
from
aa043e7 to
cd1bd1d
Compare
dmitryax
reviewed
Sep 30, 2022
exporter/signalfxexporter/internal/translation/converter_test.go
Outdated
Show resolved
Hide resolved
dloucasfx
force-pushed
the
dim-validation
branch
from
cd1bd1d to
0903fe4
Compare
dmitryax
reviewed
Sep 30, 2022
dloucasfx
force-pushed
the
dim-validation
branch
from
0903fe4 to
0a21d96
Compare
|
@dmitryax @rmfitzpatrick |
exporter/signalfxexporter/internal/translation/converter_test.go
Outdated
Show resolved
Hide resolved
rmfitzpatrick
approved these changes
Oct 3, 2022
Signed-off-by: Dani Louca <[email protected]>
dloucasfx
force-pushed
the
dim-validation
branch
from
0a21d96 to
ee650b9
Compare
dmitryax
approved these changes
Oct 3, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dani Louca [email protected]
Description:
The signalfx backend limits the number of allowed dimension to 36 https://docs.splunk.com/Observability/metrics-and-metadata/metric-names.html#dimension-name-and-value-standards
If a datapoint has more than 36 dimensions, signalfx ingest drops the datapoint as invalid without any feedback to the user.
Link to tracking Issue:
Testing:
Unit test was added
Documentation: