Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/hostmetrics] Add process.paging.faults metric #14604

Merged

Conversation

andrzej-stencel
Copy link
Member

Description:

This pull request adds a new metric named process.paging.faults to the metrics scraped by the process scraper of the hostmetrics receiver.

Adding this metric to the semantic conventions has been proposed here:

There's a related system metric system.paging.faults available in the paging scraper.

Link to tracking Issue:

@andrzej-stencel andrzej-stencel requested a review from a team September 30, 2022 10:07
@andrzej-stencel andrzej-stencel force-pushed the add-process-paging-faults-metric branch 2 times, most recently from 6c61386 to 5fe8cce Compare October 3, 2022 10:46
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 18, 2022
@dmitryax
Copy link
Member

Please rebase

@dmitryax dmitryax removed the Stale label Oct 18, 2022
@andrzej-stencel andrzej-stencel force-pushed the add-process-paging-faults-metric branch from 5fe8cce to 7374f00 Compare October 19, 2022 11:43
@dmitryax
Copy link
Member

@astencel-sumo PTAL at the failing tests

@andrzej-stencel andrzej-stencel force-pushed the add-process-paging-faults-metric branch from 5e655ed to 4fc3931 Compare October 19, 2022 23:18
@dmitryax dmitryax added the ready to merge Code review completed; ready to merge by maintainers label Oct 20, 2022
@codeboten codeboten merged commit 866e025 into open-telemetry:main Oct 21, 2022
@andrzej-stencel andrzej-stencel deleted the add-process-paging-faults-metric branch October 24, 2022 06:23
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
…etry#14604)

This pull request adds a new metric named process.paging.faults to the metrics scraped by the process scraper of the hostmetrics receiver.
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants