Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/hostmetrics] Add optional metric process.disk.operations #14566

Conversation

andrzej-stencel
Copy link
Member

Description:

This pull request adds a new metric named process.disk.operations to the metrics scraped by the process scraper of the hostmetrics receiver.

Adding this metric to the semantic conventions has been proposed here: open-telemetry/opentelemetry-specification#2812.

Link to tracking Issue:

#14084

@andrzej-stencel andrzej-stencel requested a review from a team September 28, 2022 13:07
@andrzej-stencel andrzej-stencel force-pushed the add-process-disk-operations-metric branch 2 times, most recently from 4152d69 to 9807718 Compare October 3, 2022 10:47
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 19, 2022
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase

@dmitryax dmitryax removed the Stale label Oct 19, 2022
@andrzej-stencel andrzej-stencel force-pushed the add-process-disk-operations-metric branch 2 times, most recently from ae02fe6 to 7242eae Compare October 19, 2022 12:20
@andrzej-stencel andrzej-stencel force-pushed the add-process-disk-operations-metric branch from 7242eae to e8e9fd1 Compare November 7, 2022 12:54
@andrzej-stencel
Copy link
Member Author

@dmitryax can you please take a look at this change as it is freshly rebased?

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 23, 2022
@andrzej-stencel andrzej-stencel force-pushed the add-process-disk-operations-metric branch from 19c9ee7 to b694123 Compare November 30, 2022 08:50
@github-actions github-actions bot requested a review from dmitryax November 30, 2022 08:50
@andrzej-stencel andrzej-stencel changed the title [receiver/hostmetrics] Add process.disk.operations metric [receiver/hostmetrics] Add optional metric process.disk.operations Nov 30, 2022
@github-actions github-actions bot removed the Stale label Dec 4, 2022
@andrzej-stencel andrzej-stencel force-pushed the add-process-disk-operations-metric branch from b694123 to 223c0b1 Compare December 13, 2022 14:20
@runforesight
Copy link

runforesight bot commented Dec 13, 2022

Foresight Summary

    
Major Impacts

TestConsumeLogsUnexpectedExporterType ❌ failed 4 times in 6 runs (66% fail rate).
TestConsumeTracesUnexpectedExporterType ❌ failed 4 times in 6 runs (66% fail rate).
build-and-test-windows duration(4 seconds) has decreased 40 minutes 42 seconds compared to main branch avg(40 minutes 46 seconds).
View More Details

⭕  build-and-test-windows workflow has finished in 4 seconds (40 minutes 42 seconds less than main branch avg.) and finished at 15th Dec, 2022.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  tracegen workflow has finished in 2 minutes 27 seconds (1 minute 12 seconds less than main branch avg.) and finished at 15th Dec, 2022.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details

✅  check-links workflow has finished in 2 minutes 50 seconds and finished at 15th Dec, 2022.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  changelog workflow has finished in 3 minutes 14 seconds (4 minutes 12 seconds less than main branch avg.) and finished at 15th Dec, 2022.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

❌  build-and-test workflow has finished in 29 minutes 55 seconds (30 minutes 19 seconds less than main branch avg.) and finished at 15th Dec, 2022. 1 job failed. There are 8 test failures.


Job Failed Steps Tests
unittest-matrix (1.19, internal) -     🔗  ✅ 592  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, processor) -     🔗  ✅ 1441  ❌ 0  ⏭ 0    🔗 See Details
correctness-metrics -     🔗  ✅ 2  ❌ 0  ⏭ 0    🔗 See Details
correctness-traces -     🔗  ✅ 17  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, processor) -     🔗  ✅ 1441  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-0) -     🔗  ✅ 2535  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, internal) -     🔗  ✅ 592  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, extension) -     🔗  ✅ 528  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-0) -     🔗  ✅ 2535  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-1) -     🔗  ✅ 1854  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, exporter) -     🔗  ✅ 2237  ❌ 2  ⏭ 0    🔗 See Details
unittest-matrix (1.18, extension) -     🔗  ✅ 528  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-1) -     🔗  ✅ 1854  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, exporter) -     🔗  ✅ 2237  ❌ 2  ⏭ 0    🔗 See Details
integration-tests -     🔗  ✅ 49  ❌ 4  ⏭ 0    🔗 See Details
unittest-matrix (1.18, other) -     🔗  ✅ 4363  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, other) -     🔗  ✅ 4363  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details
lint-matrix (receiver-0) -     🔗  N/A See Details
lint-matrix (receiver-1) -     🔗  N/A See Details
lint-matrix (processor) -     🔗  N/A See Details
lint-matrix (exporter) -     🔗  N/A See Details
lint-matrix (extension) -     🔗  N/A See Details
lint-matrix (internal) -     🔗  N/A See Details
lint-matrix (other) -     🔗  N/A See Details
check-collector-module-version -     🔗  N/A See Details
checks -     🔗  N/A See Details
build-examples -     🔗  N/A See Details
check-codeowners -     🔗  N/A See Details
lint -     🔗  N/A See Details
unittest (1.19) -     🔗  N/A See Details
unittest (1.18) -     🔗  N/A See Details
cross-compile (darwin, amd64) -     🔗  N/A See Details
cross-compile (darwin, arm64) -     🔗  N/A See Details
cross-compile (linux, 386) -     🔗  N/A See Details
cross-compile (linux, amd64) -     🔗  N/A See Details
cross-compile (linux, arm) -     🔗  N/A See Details
cross-compile (linux, arm64) -     🔗  N/A See Details
cross-compile (linux, ppc64le) -     🔗  N/A See Details
cross-compile (windows, 386) Build Collector     🔗  N/A See Details
cross-compile (windows, amd64) -     🔗  N/A See Details
build-package -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  load-tests workflow has finished in 11 minutes 33 seconds (5 minutes 21 seconds less than main branch avg.) and finished at 15th Dec, 2022.


Job Failed Steps Tests
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 19  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details

✅  prometheus-compliance-tests workflow has finished in 11 minutes 34 seconds (⚠️ 2 minutes 1 second more than main branch avg.) and finished at 15th Dec, 2022.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@andrzej-stencel
Copy link
Member Author

@dmitryax any chance this optional metric can be added?

@dmitryax
Copy link
Member

Hi @astencel-sumo sorry for the delay, can you please rebase?

@andrzej-stencel andrzej-stencel force-pushed the add-process-disk-operations-metric branch from 223c0b1 to 0f5178f Compare December 15, 2022 07:31
@andrzej-stencel
Copy link
Member Author

andrzej-stencel commented Dec 15, 2022

Hi @astencel-sumo sorry for the delay, can you please rebase?

With pleasure @dmitryax 🙂 Done

The build-and-test / cross-compile (windows, 386) job failure seems to be caused by this change in otel core: open-telemetry/opentelemetry-collector#6722

@dmitryax dmitryax merged commit 50333f4 into open-telemetry:main Dec 20, 2022
@andrzej-stencel andrzej-stencel deleted the add-process-disk-operations-metric branch December 21, 2022 13:13
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants