[receiver/mysql]: add endpoint resource attribute #14340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
reviewed
Sep 21, 2022
receiver/mysqlreceiver/metadata.yaml
Outdated
| @@ -1,5 +1,10 @@ | |||
| name: mysqlreceiver | |||
|
|
|||
| resource_attributes: | |||
| endpoint: | |||
There was a problem hiding this comment.
Resource attributes are part of a single hierarchy that must cover the whole project, so we need to name this more specifically.
I suggest mysql.instance.endpoint. In the future, when we add mysql database specific metrics, we'll likely add mysql.database.name and/or mysql.database.id, and those metrics will belong to a resource with both instance and database attributes.
aboguszewski-sumo
force-pushed
the
mysql-add-server-attr
branch
from
5141c2f to
ff7d936
Compare
djaglowski
reviewed
Sep 21, 2022
| @@ -0,0 +1,5 @@ | |||
| change_type: enhancement | |||
There was a problem hiding this comment.
Technically, I think we need to call this a breaking change, as it may break data continuity for some consumers.
aboguszewski-sumo
force-pushed
the
mysql-add-server-attr
branch
from
ff7d936 to
06b648c
Compare
djaglowski
approved these changes
Sep 22, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add mysql.instance.endpoint resource attribute.
Link to tracking Issue:
#14138
Testing:
Unit tests have their expected results modified.
Integration tests have not been modified, because it seems that they don't compare resources anyway (I tested that and the tests were passing even with wrong expected result).
Documentation:
Documentation automatically generated my
mdatagen.