[exporter/loki] Fix converting log resources to loki labels for multiple log lines #14333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogeriospinaintelipost
changed the title
|
@kovrus, can you review this one? |
dmitryax
approved these changes
Sep 26, 2022
Co-authored-by: Ruslan Kovalov <[email protected]>
jpkrohling
approved these changes
Sep 27, 2022
| @@ -63,6 +59,10 @@ func LogsToLoki(ld plog.Logs) (*logproto.PushRequest, *PushReport) { | |||
| log := plog.NewLogRecord() | |||
| logs.At(k).CopyTo(log) | |||
|
|
|||
| // we may remove attributes, so we make a copy and change our version | |||
| resource := pcommon.NewResource() | |||
There was a problem hiding this comment.
I have a feeling we can optimize this, but I'm OK with this approach for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
See the issue description in #14288
Link to tracking Issue:
Resolves #14288
Testing:
Unit tests.