[extension/bearertokenauthextension] support reading tokens from file #14326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frzifus
force-pushed
the
bearertokenauthextension_support_token_from_file
branch
from
89ea2bb to
5081cfc
Compare
This commit extends the bearer token extension by the possibility to read tokens from a file. Signed-off-by: Benedikt Bongartz <[email protected]>
Signed-off-by: Benedikt Bongartz <[email protected]>
frzifus
force-pushed
the
bearertokenauthextension_support_token_from_file
branch
from
5081cfc to
8545df2
Compare
jpkrohling
reviewed
Sep 26, 2022
| } | ||
|
|
||
| if b.shutdownCH != nil { | ||
| return fmt.Errorf("bearerToken file monitoring is already running") |
There was a problem hiding this comment.
When would this be the case?
There was a problem hiding this comment.
The shutdown channel is created when the extension is started and removed when stop is called. This channel condition is used to prevent another watcher from being spawned.
There was a problem hiding this comment.
Is this happening when the component is started twice without being shut down?
There was a problem hiding this comment.
Hopefully never. But yes, in case it get started twice, before it was stopped.
Signed-off-by: Benedikt Bongartz <[email protected]>
Signed-off-by: Benedikt Bongartz <[email protected]>
Signed-off-by: Benedikt Bongartz <[email protected]>
Signed-off-by: Benedikt Bongartz <[email protected]>
Signed-off-by: Benedikt Bongartz <[email protected]>
Signed-off-by: Benedikt Bongartz <[email protected]>
…ogger Signed-off-by: Benedikt Bongartz <[email protected]>
frzifus
force-pushed
the
bearertokenauthextension_support_token_from_file
branch
from
d30f1c5 to
7b7f712
Compare
jpkrohling
approved these changes
Sep 29, 2022
frzifus
deleted the
bearertokenauthextension_support_token_from_file
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pr extends the bearer token extension by the possibility to read tokens from a file. If a token file has been specified, this file is read once when the extension is started and overwrites the old token. Only if the content of the token changes again, the transferred token will be overwritten again.
Link to tracking Issue: #14325
Testing:
Documentation:
Updated extension Readme