Logicmonitorexporter implementation #14182
Conversation
|
@khyatigandhi6 can you please resolve merge conflicts |
khyatigandhi6
requested review from
djaglowski,
dmitryax,
Aneurysm9 and
dashpole
as code owners
khyatigandhi6
requested review from
jpkrohling,
TylerHelmuth,
jsuereth,
punya and
mx-psi
as code owners
|
@Aneurysm9 Can you please review this |
|
@dmitryax are you the rotating sponsor for this component? |
|
Hi @Aneurysm9 , |
|
Who is the sponsor of this component? I still see #13727 tagged as needing a sponsor. |
|
@bogdandrutu, it looks like you are the assigned sponsor for this one. |
|
@khyatigandhi6 can you please resolve the merge conflicts |
|
Hi Team, |
khyatigandhi6
removed request for
jpkrohling,
jsuereth,
punya,
Aneurysm9 and
bogdandrutu
khyatigandhi6
requested review from
mx-psi
and removed request for
dashpole,
djaglowski and
TylerHelmuth
|
Removing the 'request changes' since it was addressed. @bogdandrutu this is on you as the sponsor :) |
|
@bogdandrutu can we please get some 👀 to it. |
| require github.com/logicmonitor/lm-data-sdk-go v0.5.0 // indirect | ||
|
|
||
| require ( |
| @@ -0,0 +1 @@ | |||
| include ../../Makefile.Common | |||
| // LMAuthenticator is used for authenticating requests to Logicmonitor platform | ||
| type LMAuthenticator struct { | ||
| Config *Config | ||
| } |
There was a problem hiding this comment.
Why public? Who is using this?
| // URL on which the logs/traces should be forwarded | ||
| URL string `mapstructure:"url"` |
There was a problem hiding this comment.
confighttp.HTTPClientSettings already has notion of "endpoint" this is confusing.
| // Headers for HTTP requests | ||
| Headers map[string]string `mapstructure:"headers"` | ||
|
|
There was a problem hiding this comment.
Already defined in HTTPClientSettings https://github.com/open-telemetry/opentelemetry-collector/blob/main/config/confighttp/confighttp.go#L57
|
Consider to follow the rules in:https://github.com/open-telemetry/opentelemetry-collector/blob/main/CONTRIBUTING.md#when-adding-a-new-component |
|
Thanks @bogdandrutu for the review comments! |
Description:
Adding new component logicmonitorexporter for exporting traces and logs to Logicmonitor.
Link to tracking Issue: #13727
Testing: Added unit test cases.
Documentation: Details are mentioned in README.md file.