Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/fluentforward] Add case to handle uint64 timestamp #13868

Merged
merged 1 commit into from
Sep 29, 2022
Merged

[receiver/fluentforward] Add case to handle uint64 timestamp #13868

merged 1 commit into from
Sep 29, 2022

Conversation

bhogayatakb
Copy link
Contributor

Link to tracking Issue: #11435

@bhogayatakb bhogayatakb requested a review from a team September 5, 2022 10:43
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 5, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: bhogayatakb / name: Keval Bhogayata (78a501305a2b82eb860f1ecc31aebc379dc0232c)

@bogdandrutu
Copy link
Member

Lint errors, please fix

@djaglowski djaglowski changed the title case added to handle uint64 timestamp [receiver/fluentforward] Add case to handle uint64 timestamp Sep 7, 2022
@bhogayatakb
Copy link
Contributor Author

@bogdandrutu Linting applied & Commit Ammended

@bhogayatakb
Copy link
Contributor Author

bhogayatakb commented Sep 8, 2022 •
edited
Loading

Let me know if there is anything I can do for the failing checks, @bogdandrutu @dmitryax

@dmitryax
Copy link
Member

@bhogayatakb can you please add a changelog entry and a test case?

@bhogayatakb
Copy link
Contributor Author

bhogayatakb commented Sep 14, 2022 •
edited
Loading

There was a testcase expecting uint to be an invalid type. As we are considering uint as a valid type for timestamp - this testcase should no longer be relevant, right ? [Refer the file changes - receiver/fluentforwardreceiver/conversion_test.go]

@bhogayatakb
Copy link
Contributor Author

@dmitryax added changelog entry and made changes in test cases, there is a failing check regarding integration test for rabbitmq, should I be making any changes to pass that test ?

codeboten
codeboten reviewed Sep 16, 2022
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've restarted the job 👍🏻

@bhogayatakb
Copy link
Contributor Author

@dmitryax @bogdandrutu checks passed, is it good to go ?

@bogdandrutu bogdandrutu merged commit d6c3f1a into open-telemetry:main Sep 29, 2022
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten left review comments

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu

Assignees

@bogdandrutu bogdandrutu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bhogayatakb @bogdandrutu @dmitryax @codeboten