[pkg/telemetryquerylanguage] Add TQL mapping functions for InstrumentationScope attributes #13640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
changed the title
TylerHelmuth
approved these changes
Aug 26, 2022
TylerHelmuth
added
the
ready to merge
|
@pirgeo please add a changelog entry for this change |
TylerHelmuth
removed
the
ready to merge
TylerHelmuth
approved these changes
Aug 26, 2022
TylerHelmuth
added
the
ready to merge
bogdandrutu
previously requested changes
Aug 26, 2022
There was a problem hiding this comment.
Blocking this because we need to stop adding copy paste code. Waiting for #13650
|
@pirgeo please rebase this. |
TylerHelmuth
removed
the
ready to merge
pirgeo
force-pushed
the
instrumentation_scope-attributes
branch
from
0c1be3a to
928c613
Compare
|
Since the underlying change made this a very small change, I reorganized the commits a bit. |
TylerHelmuth
approved these changes
Aug 30, 2022
TylerHelmuth
added
ready to merge
|
@pirgeo can you address the build failures? |
Co-authored-by: Tyler Helmuth <[email protected]>
pirgeo
force-pushed
the
instrumentation_scope-attributes
branch
from
3dfe554 to
38bb896
Compare
TylerHelmuth
added
the
ready to merge
bogdandrutu
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds mapping functions for InstrumentationLibraryScope.
Link to tracking Issue:
Resolves #13639
Documentation: Updated the respective README.md files.