[exporter/mezmoexporter] Remove hardcoded "otel" hostname #13410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners
force-pushed
the
mezmo/replace-hardcoded-host
branch
from
e757267 to
9f14141
Compare
dashpole
approved these changes
Aug 18, 2022
jsumners
force-pushed
the
mezmo/replace-hardcoded-host
branch
from
587b861 to
278bf7f
Compare
This change removes the hardcoded "otel" hostname that was embedded in outgoing logs data. It is replaced by: 1. Sending to a new collector endpoint that does not require the hostname parameter. 2. Recognizing the "host.name" resource attribute and using that value to fill in log metadata recognized upstream. This is a breaking change, and as such will generate a startup error if the exporter is configured to send to an endpoint that does not support this feature.
jsumners
force-pushed
the
mezmo/replace-hardcoded-host
branch
from
278bf7f to
2723f8a
Compare
|
Is it necessary to keep updating the branch? Prior to the the changelog yaml files we needed to do so due to conflicts in the changelog file. Thankfully, that's no longer an issue. But GitHub still keeps complaining that the branch is out-of-date with the base branch every few hours (i.e. I'll updated, merges will happen, and I'll need to update it again). |
|
Is there anything else I need to do to move this one forward? |
dashpole
added
the
ready to merge
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change removes the hardcoded "otel" hostname that was embedded
in outgoing logs data. It is replaced by:
hostname parameter.
value to fill in log metadata recognized upstream.
This is a breaking change, and as such will generate a startup
error if the exporter is configured to send to an endpoint that
does not support this feature.
Testing:
The changes in this PR were used to send data to the Mezmo service. The collector was configured with both a syslog receiver and a tcplog receiver. Data from each receiver was correctly received and stored in the Mezmo system.
Documentation:
All documentation associated with this exporter was updated to match the new requirements and changes to Mezmo's upstream documentation (re: our name change from LogDNA to Mezmo).