Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/hostmetrics] Add new process metrics #12972

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

evan-bradley
Copy link
Contributor

@evan-bradley evan-bradley commented Aug 4, 2022

Description:

Add the following process metrics:

  • process.context_switches
  • process.open_file_descriptors

Link to tracking Issue:#12482

Spec PR to add semantic conventions for the added metrics: open-telemetry/opentelemetry-specification#2706

Testing:

Unit tests and manual testing of the metrics.

@dmitryax
Copy link
Member

dmitryax commented Aug 4, 2022

@evan-bradley did you submit a spec PR for adding semantic conventions for these metrics?

@evan-bradley
Copy link
Contributor Author

I opened the following spec PR to add these metrics to the semantic conventions: open-telemetry/opentelemetry-specification#2706

@dmitryax
Copy link
Member

dmitryax commented Aug 4, 2022

I opened the following spec PR to add these metrics to the semantic conventions: open-telemetry/opentelemetry-specification#2706

Thanks! Let's make sure that PR is merged first

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 20, 2022
@evan-bradley
Copy link
Contributor Author

This is currently waiting on open-telemetry/opentelemetry-specification#2726 to be resolved to determine which direction to take with open-telemetry/opentelemetry-specification#2706. I will update this PR as soon as the semantic conventions PR has been merged.

@github-actions github-actions bot removed the Stale label Aug 24, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Sep 28, 2022
@evan-bradley evan-bradley force-pushed the issue-12482 branch 2 times, most recently from 0645b27 to ba57ec3 Compare September 29, 2022 17:50
@github-actions github-actions bot removed the Stale label Sep 30, 2022
@evan-bradley
Copy link
Contributor Author

evan-bradley commented Sep 30, 2022

@dmitryax Please take a look. The PR for the semantic conventions for these metrics has been merged, though it is not yet released.

@evan-bradley
Copy link
Contributor Author

@dmitryax These metrics have been included in the semantic conventions in version 1.14.0 of the specification.

@evan-bradley evan-bradley force-pushed the issue-12482 branch 2 times, most recently from 71c84a8 to 637ada7 Compare October 18, 2022 18:33
@evan-bradley
Copy link
Contributor Author

@dmitryax Please take a look. The new metrics are part of the semantic conventions, and the PR has been rebased.

@dmitryax
Copy link
Member

Need #15274 to pass CI

Add the following process metrics:
- `process.context_switches`
- `process.open_file_descriptors`
@andrzej-stencel
Copy link
Member

Can this be merged @dmitryax?

@dmitryax dmitryax merged commit e9099f1 into open-telemetry:main Nov 2, 2022
dineshg13 pushed a commit to DataDog/opentelemetry-collector-contrib that referenced this pull request Nov 21, 2022
Add the following process metrics:
- `process.context_switches`
- `process.open_file_descriptors`

Co-authored-by: Evan Bradley <[email protected]>
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
Add the following process metrics:
- `process.context_switches`
- `process.open_file_descriptors`

Co-authored-by: Evan Bradley <[email protected]>
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants