Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/zookeeperreceiver] emit metrics without direction attribute #12772

Merged
merged 6 commits into from
Jul 29, 2022

Conversation

mwear
Copy link
Member

@mwear mwear commented Jul 28, 2022

Description:
This PR updates the Zookeeper Receiver so that it can emit metrics without a direction attribute. The behavior of the direction attribute is currently controlled by the feature gates receiver.zookeeperreceiver.emitMetricsWithoutDirectionAttribute and receiver.zookeeperreceiver.emitMetricsWithDirectionAttribute. The feature gates will be available for a grace period to help users transition to metrics without a direction attribute, which will eventually become the default.

Link to tracking Issue:
#12184

Testing:
Unit testing

Documentation:
The readme has been updated to document the feature gates and transition plan.

@mwear mwear requested a review from a team July 28, 2022 20:53
@mwear mwear requested a review from djaglowski as a code owner July 28, 2022 20:53
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mwear! LGTM

@djaglowski djaglowski merged commit 8f3c623 into open-telemetry:main Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants