[extension/observer] add ID to Endpoint.Env() #12751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmfitzpatrick
force-pushed
the
addendpointidtoenv
branch
from
0d6db0d to
f6f6c2d
Compare
jvoravong
approved these changes
Jul 27, 2022
dmitryax
approved these changes
Jul 27, 2022
dmitryax
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding a feature - Currently the
observer.Endpoint.IDisn't included in theEndpoint.Env()made available to Notify subscribers like the Receiver Creator, which can make associating dynamically created receivers with a specific Endpoint difficult, especially as endpoints change over time and as similar targets exist with much of the same details. These changes add an"id"field to the env to be able to definitively determine which endpoint is being sourced.Testing:
Updated existing unit tests
Documentation:
Updated receiver creator readme with Env details.